Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: lib/dom/scripts/databasebuilder.py

Issue 10513004: Implement v8-like overload resolving. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/idl/dart/dart.idl ('k') | lib/dom/scripts/generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/databasebuilder.py
diff --git a/lib/dom/scripts/databasebuilder.py b/lib/dom/scripts/databasebuilder.py
index 05824f1fcf8db479762a3086a9feabdc2c73fe97..d5e799688c2d49f0ba275a9dd77c9f0e3cd84fef 100755
--- a/lib/dom/scripts/databasebuilder.py
+++ b/lib/dom/scripts/databasebuilder.py
@@ -125,9 +125,8 @@ class DatabaseBuilder(object):
for op in interface.operations:
for argument in op.arguments:
in_optional_whitelist = (interface.id, op.id, argument.id) in optional_argument_whitelist
- if in_optional_whitelist or set(['Optional', 'Callback']).issubset(argument.ext_attrs.keys()):
+ if in_optional_whitelist:
argument.ext_attrs['Optional'] = None
- argument.ext_attrs['RequiredCppParameter'] = None
def _rename_types(self, idl_file, import_options):
"""Rename interface and type names with names provided in the
« no previous file with comments | « lib/dom/idl/dart/dart.idl ('k') | lib/dom/scripts/generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698