Issue 10512016: Get rid of internal content includes for sandbox code from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10512016: Get rid of internal content includes for sandbox code from chrome. (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, jam, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of internal content includes for sandbox code from chrome. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140357

Patch Set 1 #

Patch Set 2 : update deps! #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -33 lines)			Patch
M	chrome/DEPS	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/DEPS	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/autofill/autofill_browsertest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/nacl/nacl_broker_listener.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/nacl/nacl_main_platform_delegate_mac.mm	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/service/service_main.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/service/service_utility_process_host.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/sandbox_policy.h	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	content/common/sandbox_policy.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/public/common/sandbox_init.h	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

8 years, 6 months ago (2012-06-04 20:05:39 UTC) #3

btw I added the content/common DEPS lockdown since the other change landed
already.

Expand Messages | Collapse Messages