Issue 10511019: Fix gyp on Android called by gclient or makefile regen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10511019: Fix gyp on Android called by gclient or makefile regen (Closed)

Created:
8 years, 6 months ago by Xianzhu

Modified:
8 years, 6 months ago

Reviewers:
John Grabowski, Yaron

CC:
chromium-reviews, nilesh, Ramya

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix gyp on Android called by gclient or makefile regen v8/build/common.gypi now uses environment variable CXX_target which is only set in android_gyp, not set when gyp_chromium is called by gclient or automatic makefile regeneration. Now exports the environment variables needed by gyp generation. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140431

Patch Set 1 #

Patch Set 2 : Fixed a typo #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+11 lines, -10 lines	0 comments	Download
	M	build/common.gypi	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10511019/3001

8 years, 6 months ago (2012-06-04 22:04:44 UTC) #3

Change committed as 140431

Expand Messages | Collapse Messages