Support overriding fields with fields.

Support overriding fields with fields.

Committed: https://code.google.com/p/dart/source/detail?r=8312

[ahe, 2012-06-04 12:57:52]

Currently running tests. There may be further status file changes.

[ngeoffray, 2012-06-04 13:27:27]

LGTM

https://chromiumcodereview.appspot.com/10511008/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10511008/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/emitter.dart:407: 'function(){return
this.$fieldName}');
Please add spaces and semi-colon in the generated code (Don't know if you also
need to emit '\n' here.

[ahe, 2012-06-04 15:48:42]

PTAL, first attempt was flawed, almost a complete rewrite. All tests are
passing.

https://chromiumcodereview.appspot.com/10511008/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10511008/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/emitter.dart:407: 'function(){return
this.$fieldName}');
On 2012/06/04 13:27:27, ngeoffray wrote:
> Please add spaces and semi-colon in the generated code

Why?

> (Don't know if you also
> need to emit '\n' here.


I don't think so, the generated code looks like this:

 get$foo: function(){return this.lib$B$foo},
 set$foo: function(x){this.lib$B$foo = x}

Looks like defineInstanceMember takes care to add newlines.

[ngeoffray, 2012-06-04 16:08:51]

STV!