Issue 10510005: Hide TestRenderViewHostFactory from embedders since it depends on internal content classes. Expose …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10510005: Hide TestRenderViewHostFactory from embedders since it depends on internal content classes. Expose … (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Hide TestRenderViewHostFactory from embedders since it depends on internal content classes. Expose a method to allow the WebViewTestHelper to enable the creation of test RenderViewHosts. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140288

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -14 lines)			Patch
M	content/public/browser/render_process_host_factory.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	content/public/test/test_content_client_initializer.h	View		2 chunks	+9 lines, -0 lines	2 comments	Download
M	content/test/test_content_client_initializer.cc	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/views/test/webview_test_helper.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/views/test/webview_test_helper.cc	View	1 2	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

lgtm with nit http://codereview.chromium.org/10510005/diff/5002/content/public/test/test_content_client_initializer.h File content/public/test/test_content_client_initializer.h (right): http://codereview.chromium.org/10510005/diff/5002/content/public/test/test_content_client_initializer.h#newcode30 content/public/test/test_content_client_initializer.h:30: // of the real implementation. This ...

8 years, 6 months ago (2012-06-04 14:26:50 UTC) #2

jam

8 years, 6 months ago (2012-06-04 14:46:14 UTC) #3

http://codereview.chromium.org/10510005/diff/5002/content/public/test/test_co...
File content/public/test/test_content_client_initializer.h (right):

http://codereview.chromium.org/10510005/diff/5002/content/public/test/test_co...
content/public/test/test_content_client_initializer.h:30: // of the real
implementation. This will list throughout the lifetime of this
On 2012/06/04 14:26:51, Avi wrote:
> s/list/last/

Done.

Expand Messages | Collapse Messages