Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: third_party/harfbuzz-ng/src/hb-graphite2.cc

Issue 10510004: Roll harfbuzz-ng 3b8fd9c48f4bde368bf2d465c148b9743a9216ee (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/harfbuzz-ng/src/hb-graphite2.h ('k') | third_party/harfbuzz-ng/src/hb-graphite2-private.hh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/src/hb-graphite2.cc
diff --git a/third_party/harfbuzz-ng/src/hb-graphite2.cc b/third_party/harfbuzz-ng/src/hb-graphite2.cc
index 067575968a4468c23396acf242419872ef306806..eab2eae72b60fdb9c62fe64559bb1e9b04b29b33 100644
--- a/third_party/harfbuzz-ng/src/hb-graphite2.cc
+++ b/third_party/harfbuzz-ng/src/hb-graphite2.cc
@@ -130,6 +130,7 @@ static void _hb_gr_font_data_destroy (void *data)
hb_gr_font_data_t *f = (hb_gr_font_data_t *) data;
gr_font_destroy (f->grfont);
+ free (f);
}
static hb_user_data_key_t hb_gr_data_key;
@@ -212,15 +213,17 @@ _hb_gr_font_get_data (hb_font_t *font)
hb_bool_t
-hb_graphite_shape (hb_font_t *font,
+_hb_graphite_shape (hb_font_t *font,
hb_buffer_t *buffer,
const hb_feature_t *features,
- unsigned int num_features,
- const char * const *shaper_options)
+ unsigned int num_features)
{
buffer->guess_properties ();
+ /* XXX We do a hell of a lot of stuff just to figure out this font
+ * is not graphite! Shouldn't do. */
+
hb_gr_font_data_t *data = _hb_gr_font_get_data (font);
if (!data->grface) return FALSE;
@@ -244,11 +247,10 @@ hb_graphite_shape (hb_font_t *font,
features++;
}
- unsigned short *gids = NULL;
+ hb_codepoint_t *gids = NULL, *pg;
hb_gr_cluster_t *clusters = NULL;
gr_segment *seg = NULL;
uint32_t *text = NULL;
- unsigned short *pg;
const gr_slot *is;
unsigned int ci = 0, ic = 0;
float curradvx = 0., curradvy = 0.;
@@ -277,7 +279,7 @@ hb_graphite_shape (hb_font_t *font,
clusters = (hb_gr_cluster_t *) calloc (charlen, sizeof (hb_gr_cluster_t));
if (!glyphlen || !clusters) goto dieout;
- gids = (uint16_t *) malloc (glyphlen * sizeof (uint16_t));
+ gids = (hb_codepoint_t *) malloc (glyphlen * sizeof (hb_codepoint_t));
if (!gids) goto dieout;
pg = gids;
« no previous file with comments | « third_party/harfbuzz-ng/src/hb-graphite2.h ('k') | third_party/harfbuzz-ng/src/hb-graphite2-private.hh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698