src/codec/SkCodec_libpng.h - Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libpng.h

Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind. (Closed) Base URL: https://skia.googlesource.com/skia.git@pngRewind

Patch Set: All codecs can now rewind. Remove code to support unrewindable codecs. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libpng.h

diff --git a/src/codec/SkCodec_libpng.h b/src/codec/SkCodec_libpng.h

index 527efb75b70e8eaaa83dd0b6948737585562556c..103839b314d5f899ea110bf62997e85595f4fe9a 100644

--- a/src/codec/SkCodec_libpng.h

+++ b/src/codec/SkCodec_libpng.h

@@ -50,6 +50,8 @@ private:

// Helper to set up swizzler and color table. Also calls png_read_update_info.

Result initializeSwizzler(const SkImageInfo& requestedInfo, void* dst,

size_t rowBytes, const Options&);

+ // Calls rewindIfNeeded, and returns true if the decoder can continue.

+ bool handleRewind();

bool decodePalette(bool premultiply);

void finish();

void destroyReadStruct();

« no previous file with comments | « src/codec/SkCodec.cpp ('k') | src/codec/SkCodec_libpng.cpp » ('j') | no next file with comments »