Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 10505010: Root solution for src/cloud_print. (Closed)

Created:
8 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, gene
Visibility:
Public.

Description

Single binary for unittests. Root solution for src/cloud_print. Build cloud_print_unittests on bots. Added virtual_driver_lib with shared files. Moved service_state out of win dir as platform independent. BUG=131058 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140703

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -695 lines) Patch
M build/all.gyp View 1 10 chunks +10 lines, -3 lines 0 comments Download
A cloud_print/cloud_print.gyp View 1 chunk +48 lines, -0 lines 0 comments Download
A + cloud_print/service/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cloud_print/service/service.gyp View 3 chunks +10 lines, -25 lines 0 comments Download
A + cloud_print/service/service_state.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cloud_print/service/service_state.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cloud_print/service/service_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cloud_print/service/service_switches.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cloud_print/service/service_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
D cloud_print/service/win/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D cloud_print/service/win/service.gyp View 1 chunk +0 lines, -66 lines 0 comments Download
D cloud_print/service/win/service_state.h View 1 chunk +0 lines, -103 lines 0 comments Download
D cloud_print/service/win/service_state.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D cloud_print/service/win/service_state_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D cloud_print/service/win/service_switches.h View 1 chunk +0 lines, -19 lines 0 comments Download
D cloud_print/service/win/service_switches.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D cloud_print/virtual_driver/virtual_driver.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 2 chunks +3 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 5 chunks +5 lines, -68 lines 0 comments Download
A cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 chunk +10 lines, -1 line 0 comments Download
D cloud_print/virtual_driver/win/port_monitor/virtual_driver_port_monitor.gyp View 1 chunk +0 lines, -66 lines 0 comments Download
A cloud_print/virtual_driver/win/virtual_driver.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A cloud_print/virtual_driver/win/virtual_driver.gypi View 1 chunk +53 lines, -0 lines 0 comments Download
A cloud_print/virtual_driver/win/virtual_driver64.gyp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
It looks bit, but most changes in gyp files and c++ code just moved.
8 years, 6 months ago (2012-06-03 00:19:38 UTC) #1
Vitaly Buka (NO REVIEWS)
On 2012/06/03 00:19:38, Vitaly Buka wrote: > It looks bit, but most changes in gyp ...
8 years, 6 months ago (2012-06-03 00:20:52 UTC) #2
Albert Bodenhamer
Please file a bug to track this and a note in the CL description explaining ...
8 years, 6 months ago (2012-06-03 03:21:17 UTC) #3
Vitaly Buka (NO REVIEWS)
On 2012/06/03 03:21:17, Albert Bodenhamer wrote: > Please file a bug to track this and ...
8 years, 6 months ago (2012-06-04 19:35:53 UTC) #4
Albert Bodenhamer
lgtm
8 years, 6 months ago (2012-06-04 22:27:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10505010/17001
8 years, 6 months ago (2012-06-05 23:14:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10505010/19004
8 years, 6 months ago (2012-06-06 00:30:40 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-06 02:42:09 UTC) #8
Change committed as 140703

Powered by Google App Engine
This is Rietveld 408576698