Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: dbus/string_util.cc

Issue 10502011: Explicitly CHECK arguments in dbus::MessageWriter::AppendString/ObjectPath (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dbus/string_util.h ('k') | dbus/string_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "dbus/string_util.h"
6
7 #include "base/string_util.h"
8
9 namespace dbus {
10
11 bool IsValidObjectPath(const std::string& value) {
12 // This implementation is based upon D-Bus Specification Version 0.19.
13
14 const bool kCaseSensitive = true;
15
16 // A valid object path begins with '/'.
17 if (!StartsWithASCII(value, "/", kCaseSensitive))
18 return false;
19
20 // Elements are pieces delimited by '/'. For instance, "org", "chromium",
21 // "Foo" are elements of "/org/chromium/Foo".
22 int element_length = 0;
23 for (size_t i = 1; i < value.size(); ++i) {
24 const char c = value[i];
25 if (c == '/') {
26 // No element may be the empty string.
27 if (element_length == 0)
28 return false;
29 element_length = 0;
30 } else {
31 // Each element must only contain "[A-Z][a-z][0-9]_".
32 const bool is_valid_character =
33 ('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z') ||
34 ('0' <= c && c <= '9') || c == '_';
35 if (!is_valid_character)
36 return false;
37 element_length++;
38 }
39 }
40
41 // A trailing '/' character is not allowed unless the path is the root path.
42 if (value.size() > 1 && EndsWith(value, "/", kCaseSensitive))
43 return false;
44
45 return true;
46 }
47
48 } // namespace dbus
OLDNEW
« no previous file with comments | « dbus/string_util.h ('k') | dbus/string_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698