Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 10501012: Move mock download test headers from content\test to content\public\test. This way we can enforce t… (Closed)

Created:
8 years, 6 months ago by jam
Modified:
8 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Move mock download test headers from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140208

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -254 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_file_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/test/mock_download_item.h View 2 chunks +3 lines, -6 lines 0 comments Download
A + content/public/test/mock_download_manager.h View 3 chunks +6 lines, -6 lines 1 comment Download
D content/test/mock_download_item.h View 1 chunk +0 lines, -129 lines 0 comments Download
M content/test/mock_download_item.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/test/mock_download_manager.h View 1 chunk +0 lines, -97 lines 0 comments Download
M content/test/mock_download_manager.cc View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 6 months ago (2012-06-02 21:16:20 UTC) #1
Paweł Hajdan Jr.
8 years, 6 months ago (2012-06-04 10:57:47 UTC) #2
LGTM

http://codereview.chromium.org/10501012/diff/1/content/public/test/mock_downl...
File content/public/test/mock_download_manager.h (right):

http://codereview.chromium.org/10501012/diff/1/content/public/test/mock_downl...
content/public/test/mock_download_manager.h:17: void PrintTo(const
DownloadRequestHandle& params, std::ostream* os);
This is ugly. Could you please add a TODO there (can be for me) to make it more
pretty? Thanks.

http://codereview.chromium.org/10501012/diff/1/content/test/mock_download_man...
File content/test/mock_download_manager.cc (right):

http://codereview.chromium.org/10501012/diff/1/content/test/mock_download_man...
content/test/mock_download_manager.cc:7: void PrintTo(const
DownloadRequestHandle& params, std::ostream* os) {
Won't this result in some weird double definition for PrintTo? If this is OK I'm
fine, I just don't remember how original PrintTo is defined, and cs.chromium.org
is not helpful to check this.

Powered by Google App Engine
This is Rietveld 408576698