Issue 10501006: Connect up flash blacklist entries to GetSettingInt

Issue 10501006: Connect up flash blacklist entries to GetSettingInt (Closed)

Created:
8 years, 6 months ago by jbauman

Modified:
8 years, 6 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Connect up flash blacklist entries to GetSettingInt This allows us to blacklist flash 3d and stage3d separately. BUG=129847 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140414

Patch Set 1 #

Total comments: 1

Patch Set 2 : clarify comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -6 lines)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/api/private/ppb_flash.idl	View	1	2 chunks	+13 lines, -1 line	0 comments	Download
M	ppapi/c/private/ppb_flash.h	View	1	3 chunks	+13 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_preferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_preferences.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://chromiumcodereview.appspot.com/10501006/diff/1/ppapi/api/private/ppb_flash.idl File ppapi/api/private/ppb_flash.idl (right): https://chromiumcodereview.appspot.com/10501006/diff/1/ppapi/api/private/ppb_flash.idl#newcode41 ppapi/api/private/ppb_flash.idl:41: * should only be used for drawing 2d ...

8 years, 6 months ago (2012-06-04 21:06:28 UTC) #2

jbauman

Darin, could you do an OWNERS review for the webkit/ part? Also, I added some ...

8 years, 6 months ago (2012-06-04 21:45:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/10501006/5001

8 years, 6 months ago (2012-06-04 21:52:45 UTC) #5

Change committed as 140414

Expand Messages | Collapse Messages