content/browser/download/download_manager_impl.cc - Issue 10501004: Refactor the guts of ResourceDispatcherHostImpl into a new class named

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 10501004: Refactor the guts of ResourceDispatcherHostImpl into a new class named (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | content/browser/download/download_resource_handler.cc » ('j') | content/browser/renderer_host/resource_dispatcher_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_manager_impl.cc

===================================================================

--- content/browser/download/download_manager_impl.cc (revision 141889)

+++ content/browser/download/download_manager_impl.cc (working copy)

@@ -53,11 +53,8 @@

// ResourceDispatcherHost{Base} is-not-a URLRequest::Delegate, and

// DownloadUrlParameters can-not include resource_dispatcher_host_impl.h, so

// we must down cast. RDHI is the only subclass of RDH as of 2012 May 4.

- content::ResourceDispatcherHostImpl* resource_dispatcher_host =

- static_cast<content::ResourceDispatcherHostImpl*>(

- params->resource_dispatcher_host());

scoped_ptr<net::URLRequest> request(new net::URLRequest(

- params->url(), resource_dispatcher_host));

+ params->url(), NULL));

request->set_referrer(params->referrer().url.spec());

webkit_glue::ConfigureURLRequestForReferrerPolicy(

request.get(), params->referrer().policy);

@@ -84,7 +81,7 @@

request->SetExtraRequestHeaderByName(

iter->first, iter->second, false/*overwrite*/);

}

- resource_dispatcher_host->BeginDownload(

+ params->resource_dispatcher_host()->BeginDownload(

request.Pass(),

params->content_initiated(),

params->resource_context(),