Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2876)

Unified Diff: chrome/browser/policy/asynchronous_policy_loader_unittest.cc

Issue 10500013: Delete old policy code after AsyncPolicyLoader refactor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebased Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/asynchronous_policy_loader_unittest.cc
diff --git a/chrome/browser/policy/asynchronous_policy_loader_unittest.cc b/chrome/browser/policy/asynchronous_policy_loader_unittest.cc
deleted file mode 100644
index 8828735efcfbf074f0d3242564b8fb2ac2349961..0000000000000000000000000000000000000000
--- a/chrome/browser/policy/asynchronous_policy_loader_unittest.cc
+++ /dev/null
@@ -1,151 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/bind.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/browser/policy/asynchronous_policy_loader.h"
-#include "chrome/browser/policy/asynchronous_policy_provider.h"
-#include "chrome/browser/policy/asynchronous_policy_test_base.h"
-#include "chrome/browser/policy/mock_configuration_policy_provider.h"
-#include "chrome/browser/policy/policy_bundle.h"
-#include "chrome/browser/policy/policy_map.h"
-#include "testing/gmock/include/gmock/gmock.h"
-
-using ::testing::InSequence;
-using ::testing::Mock;
-using ::testing::Return;
-using ::testing::_;
-
-namespace policy {
-
-namespace {
-
-void AddSequencedTestPolicy(PolicyBundle* bundle, int* number) {
- bundle->Get(POLICY_DOMAIN_CHROME, "")
- .Set("id", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(++(*number)));
-}
-
-} // namespace
-
-class AsynchronousPolicyLoaderTest : public AsynchronousPolicyTestBase {
- public:
- AsynchronousPolicyLoaderTest() {}
- virtual ~AsynchronousPolicyLoaderTest() {}
-
- virtual void SetUp() {
- AsynchronousPolicyTestBase::SetUp();
- update_callback_ = base::Bind(&AsynchronousPolicyLoaderTest::UpdateCallback,
- base::Unretained(this));
- }
-
- protected:
- AsynchronousPolicyLoader::UpdateCallback update_callback_;
- scoped_ptr<PolicyBundle> bundle_;
-
- private:
- void UpdateCallback(scoped_ptr<PolicyBundle> bundle) {
- bundle_.swap(bundle);
- }
-
- DISALLOW_COPY_AND_ASSIGN(AsynchronousPolicyLoaderTest);
-};
-
-TEST_F(AsynchronousPolicyLoaderTest, InitialLoad) {
- PolicyBundle template_bundle;
- template_bundle.Get(POLICY_DOMAIN_CHROME, "")
- .Set("test", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123));
- template_bundle.Get(POLICY_DOMAIN_EXTENSIONS, "extension-id")
- .Set("test", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123));
- ProviderDelegateMock* delegate = new ProviderDelegateMock();
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&template_bundle));
- scoped_refptr<AsynchronousPolicyLoader> loader =
- new AsynchronousPolicyLoader(delegate, 10);
- EXPECT_FALSE(bundle_.get());
- loader->Init(update_callback_);
- ASSERT_TRUE(bundle_.get());
- EXPECT_TRUE(bundle_->Equals(template_bundle));
-}
-
-// Verify that the fallback policy requests are made.
-TEST_F(AsynchronousPolicyLoaderTest, InitialLoadWithFallback) {
- int policy_number = 0;
- PolicyBundle bundle0;
- AddSequencedTestPolicy(&bundle0, &policy_number);
- PolicyBundle bundle1;
- AddSequencedTestPolicy(&bundle1, &policy_number);
- InSequence s;
- ProviderDelegateMock* delegate = new ProviderDelegateMock();
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&bundle0));
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&bundle1));
- scoped_refptr<AsynchronousPolicyLoader> loader =
- new AsynchronousPolicyLoader(delegate, 10);
- loader->Init(update_callback_);
- loop_.RunAllPending();
- loader->Reload(true);
- loop_.RunAllPending();
-
- const PolicyMap& chrome_policy =
- bundle_->Get(POLICY_DOMAIN_CHROME, std::string());
- base::FundamentalValue expected(policy_number);
- EXPECT_TRUE(base::Value::Equals(&expected, chrome_policy.GetValue("id")));
- EXPECT_EQ(1U, chrome_policy.size());
-}
-
-// Ensure that calling stop on the loader stops subsequent reloads from
-// happening.
-TEST_F(AsynchronousPolicyLoaderTest, Stop) {
- PolicyBundle bundle;
- ProviderDelegateMock* delegate = new ProviderDelegateMock();
- ON_CALL(*delegate, MockLoad()).WillByDefault(Return(&bundle));
- EXPECT_CALL(*delegate, MockLoad()).Times(1);
- scoped_refptr<AsynchronousPolicyLoader> loader =
- new AsynchronousPolicyLoader(delegate, 10);
- loader->Init(update_callback_);
- loop_.RunAllPending();
- loader->Stop();
- loop_.RunAllPending();
- loader->Reload(true);
- loop_.RunAllPending();
-}
-
-// Verifies that the provider is notified upon policy reload.
-TEST_F(AsynchronousPolicyLoaderTest, ProviderNotificationOnPolicyChange) {
- InSequence s;
- MockConfigurationPolicyObserver observer;
- int policy_number = 0;
-
- PolicyBundle bundle;
- AddSequencedTestPolicy(&bundle, &policy_number);
- ProviderDelegateMock* delegate = new ProviderDelegateMock();
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&bundle));
-
- scoped_refptr<AsynchronousPolicyLoader> loader =
- new AsynchronousPolicyLoader(delegate, 10);
- AsynchronousPolicyProvider provider(NULL, loader);
- // |registrar| must be declared last so that it is destroyed first.
- ConfigurationPolicyObserverRegistrar registrar;
- registrar.Init(&provider, &observer);
- Mock::VerifyAndClearExpectations(delegate);
-
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&bundle));
- EXPECT_CALL(observer, OnUpdatePolicy(_)).Times(1);
- provider.RefreshPolicies();
- loop_.RunAllPending();
- Mock::VerifyAndClearExpectations(delegate);
- Mock::VerifyAndClearExpectations(&observer);
-
- AddSequencedTestPolicy(&bundle, &policy_number);
- EXPECT_CALL(*delegate, MockLoad()).WillOnce(Return(&bundle));
- EXPECT_CALL(observer, OnUpdatePolicy(_)).Times(1);
- provider.RefreshPolicies();
- loop_.RunAllPending();
- Mock::VerifyAndClearExpectations(delegate);
- Mock::VerifyAndClearExpectations(&observer);
-}
-
-} // namespace policy
« no previous file with comments | « chrome/browser/policy/asynchronous_policy_loader.cc ('k') | chrome/browser/policy/asynchronous_policy_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698