Issue 10498002: This groups the ParamTraits into different categories and orders the .cc file the same. It makes al…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10498002: This groups the ParamTraits into different categories and orders the .cc file the same. It makes al… (Closed)

Created:
8 years, 6 months ago by brettw

Modified:
8 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This groups the ParamTraits into different categories and orders the .cc file the same. It makes all non-trivial Read/Write calls non-inline. TEST=it compiles BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140375

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+587 lines, -507 lines)			Patch
	M	ipc/ipc_message_utils.h	View		13 chunks	+175 lines, -370 lines	0 comments	Download
	M	ipc/ipc_message_utils.cc	View		11 chunks	+412 lines, -137 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10498002/3001

8 years, 6 months ago (2012-06-04 17:57:11 UTC) #3

commit-bot: I haz the power

8 years, 6 months ago (2012-06-04 17:57:18 UTC) #4

Presubmit check for 10498002-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    ipc/ipc_message_utils.cc:361
    ipc/ipc_message_utils.h:315
    ipc/ipc_message_utils.h:316
    ipc/ipc_message_utils.h:327

Presubmit checks took 1.1s to calculate.

Expand Messages | Collapse Messages