Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10495013: Recognize logical operations before code generation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 8244)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -1637,7 +1637,7 @@
// } else {
// t2 = t0;
// }
- // result = phi(t1, t2);
+ // result = phi(t1, false);
//
// x || y is transformed into:
// t0 = boolify(x);
@@ -1646,7 +1646,7 @@
// } else {
// t2 = t0;
// }
- // result = phi(t1, t2);
+ // result = phi(t1, true);
HInstruction boolifiedLeft;
HInstruction boolifiedRight;
@@ -1670,7 +1670,7 @@
handleIf(visitCondition, visitThen, null);
HPhi result = new HPhi.manyInputs(null,
- <HInstruction>[boolifiedRight, boolifiedLeft]);
+ <HInstruction>[boolifiedRight, graph.addConstantBool(!isAnd)]);
current.addPhi(result);
stack.add(result);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698