Recognize logical operations before code generation.

lib/compiler/implementation/ssa/nodes.dart

Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart	(revision 8225)
+++ lib/compiler/implementation/ssa/nodes.dart	(working copy)
@@ -926,6 +926,8 @@
   bool isConstantString() => false;
   bool isConstantList() => false;
   bool isConstantMap() => false;
+  bool isConstantFalse() => false;
+  bool isConstantTrue() => false;

[Lasse Reichstein Nielsen, 2012/06/04 11:09:22]

This is getting ridiculous. Will isConstant0() be next?
I can see the reason to have a shorthand for
 x.isConstant() && x.asConstant().isTrue()
but maybe make it a separate function:
 bool isConstantTrue(HInstruction x) => ...
instead of putting them all on all HInstructions.
(On the other hand, it already includes so many other specialized functions, so
a few more is probably ok).

[ngeoffray, 2012/06/04 11:37:54]

I'm duplicating what we have in the Constant class. We'll stop from there :)

 
   bool isValid() {
     HValidator validator = new HValidator();
@@ -1741,6 +1743,8 @@
   bool isConstantString() => constant.isString();
   bool isConstantList() => constant.isList();
   bool isConstantMap() => constant.isMap();
+  bool isConstantFalse() => constant.isFalse();
+  bool isConstantTrue() => constant.isTrue();
 
   // Maybe avoid this if the literal is big?
   bool isCodeMotionInvariant() => true;