Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 10495008: Further cleanup in PluginStream. (Closed)

Created:
8 years, 6 months ago by Lei Zhang
Modified:
8 years, 4 months ago
Reviewers:
Bernhard Bauer, ananta
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Further cleanup in PluginStream. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150667

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M webkit/plugins/npapi/plugin_stream.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_stream.cc View 1 2 4 chunks +10 lines, -8 lines 0 comments Download
M webkit/plugins/npapi/plugin_stream_posix.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M webkit/plugins/npapi/plugin_stream_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
8 years, 6 months ago (2012-06-03 23:30:22 UTC) #1
Lei Zhang
ping
8 years, 4 months ago (2012-07-31 06:50:46 UTC) #2
Lei Zhang
+bauerb
8 years, 4 months ago (2012-08-08 18:49:05 UTC) #3
Bernhard Bauer
lgtm
8 years, 4 months ago (2012-08-08 18:50:38 UTC) #4
ananta
lgtm
8 years, 4 months ago (2012-08-08 18:52:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10495008/18001
8 years, 4 months ago (2012-08-08 18:56:38 UTC) #6
commit-bot: I haz the power
Try job failure for 10495008-18001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 20:02:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10495008/18001
8 years, 4 months ago (2012-08-08 23:11:12 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 23:43:45 UTC) #9
Try job failure for 10495008-18001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Powered by Google App Engine
This is Rietveld 408576698