Issue 10495006: Fix TestWebKitAPI and webkit_unit_tests on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10495006: Fix TestWebKitAPI and webkit_unit_tests on Android. (Closed)

Created:
8 years, 6 months ago by Xianzhu

Modified:
8 years, 6 months ago

Reviewers:
tkent, John Grabowski

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix TestWebKitAPI and webkit_unit_tests on Android. Don't initialize Java environment for unit test mode. BUG=none TEST=run TestWebKitAPI and webkit_unit_tests on Android. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140313

Patch Set 1 #

Patch Set 2 : Add comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	webkit/support/platform_support_android.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tkent

LGTM though I don't know why initializing Java environment is harmful for unit tests. The ...

8 years, 6 months ago (2012-06-04 00:45:06 UTC) #2

Xianzhu

On 2012/06/04 00:45:06, Kent Tamura wrote: > LGTM > though I don't know why initializing ...

8 years, 6 months ago (2012-06-04 16:12:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10495006/3001

8 years, 6 months ago (2012-06-04 16:12:47 UTC) #4

Change committed as 140313

Expand Messages | Collapse Messages