Move StoragePartitionHttpCacheRemover to browsing_data/ components.

Move StoragePartitionHttpCacheRemover to browsing_data/ components.

This enables us to use StoragePartitionHttpCacheRemover from extensions/.

SPHCRemover used to live under chrome/.
WebViewGuest, which uses it lives in extensions/, we currently have to install
a chrome/ delegate (ChromeWebViewGuestDelegate) to call into SPHCRemover.
This change will enable us to use SPHCRemover directly from WebViewGuest in
extensions/.

BUG=471287
Test=None, internal only change.

Committed: https://crrev.com/14082d23ec62e040992a82a7e535d2c004874b8a
Cr-Commit-Position: refs/heads/master@{#323385}

[lazyboy, 2015-04-01 08:07:53]

lazyboy@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-04-01 08:11:04]

LGTM, but you'll need a components/ OWNER to sign off on things.

Would you mind adding a description to the CL noting why you're making this
change?

[lazyboy, 2015-04-01 08:46:18]

lazyboy@chromium.org changed reviewers:
+ blundell@chromium.org

[lazyboy, 2015-04-01 08:46:18]

I've updated the CL description, thanks!

+blundell@ for components/ OWNERS review.

[blundell, 2015-04-01 09:12:12]

lgtm with change

https://chromiumcodereview.appspot.com/1049423002/diff/20001/components/compo...
File components/components.gyp (right):

https://chromiumcodereview.appspot.com/1049423002/diff/20001/components/compo...
components/components.gyp:16: 'browsing_data.gypi',
This should only be built when not on iOS, since it depends on //content.

[blundell, 2015-04-01 09:12:42]

oh, also add file-specific owners of browsing_data.gypi to //components/OWNERS

[lazyboy, 2015-04-01 17:17:21]

Updated OWNERS file.

https://chromiumcodereview.appspot.com/1049423002/diff/20001/components/compo...
File components/components.gyp (right):

https://chromiumcodereview.appspot.com/1049423002/diff/20001/components/compo...
components/components.gyp:16: 'browsing_data.gypi',
On 2015/04/01 09:12:11, blundell wrote:
> This should only be built when not on iOS, since it depends on //content.

Done.

[lazyboy, 2015-04-01 17:19:41]

lazyboy@chromium.org changed reviewers:
+ fsamuel@chromium.org, thestig@chromium.org

[lazyboy, 2015-04-01 17:19:42]

+fsamuel for
chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+thestig for
chrome/browser/BUILD.gn
chrome/browser/DEPS

[Lei Zhang, 2015-04-01 17:51:27]

Need to fix ios...

[lazyboy, 2015-04-01 18:42:29]

Fixed ios trybots in Patch Set #4.

[Lei Zhang, 2015-04-01 19:07:53]

https://chromiumcodereview.appspot.com/1049423002/diff/60001/chrome/browser/B...
File chrome/browser/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1049423002/diff/60001/chrome/browser/B...
chrome/browser/BUILD.gn:86: "//components/browsing_data",
This doesn't match chrome/chrome_browser.gypi. This should go down to line ~234
according to the comment on line 61.

https://chromiumcodereview.appspot.com/1049423002/diff/60001/components/BUILD.gn
File components/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1049423002/diff/60001/components/BUILD...
components/BUILD.gn:25: "//components/browsing_data",
I don't think this matches the components.gypi either. You need to take this out
in the ios section below.

[lazyboy, 2015-04-01 19:28:57]

Addressed comments in Patch Set #5.

Hopefully I got them all this time.

https://chromiumcodereview.appspot.com/1049423002/diff/60001/chrome/browser/B...
File chrome/browser/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1049423002/diff/60001/chrome/browser/B...
chrome/browser/BUILD.gn:86: "//components/browsing_data",
On 2015/04/01 19:07:53, Lei Zhang wrote:
> This doesn't match chrome/chrome_browser.gypi. This should go down to line
~234
> according to the comment on line 61.

Done.

https://chromiumcodereview.appspot.com/1049423002/diff/60001/components/BUILD.gn
File components/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1049423002/diff/60001/components/BUILD...
components/BUILD.gn:25: "//components/browsing_data",
On 2015/04/01 19:07:53, Lei Zhang wrote:
> I don't think this matches the components.gypi either. You need to take this
out
> in the ios section below.

Done.

[Lei Zhang, 2015-04-01 21:11:50]

Ok, please fix this one last discrepency and then lgtm.

https://chromiumcodereview.appspot.com/1049423002/diff/80001/components/brows...
File components/browsing_data.gypi (right):

https://chromiumcodereview.appspot.com/1049423002/diff/80001/components/brows...
components/browsing_data.gypi:12: '../content/content.gyp:content_common',
Sorry, I keep finding things that don't match. Shouldn't this be content_browser
?

[Fady Samuel, 2015-04-01 21:39:40]

lgtm

[lazyboy, 2015-04-01 21:55:03]

Addressed in Patch Set #6.

https://chromiumcodereview.appspot.com/1049423002/diff/80001/components/brows...
File components/browsing_data.gypi (right):

https://chromiumcodereview.appspot.com/1049423002/diff/80001/components/brows...
components/browsing_data.gypi:12: '../content/content.gyp:content_common',
On 2015/04/01 21:11:50, Lei Zhang wrote:
> Sorry, I keep finding things that don't match. Shouldn't this be
content_browser
> ?

Yes, correct.
I'm using content/public/browser.

Thanks for pointing this out.

Orthogonal: why build doesn't complain? because we transitively end up pulling
content_browser too?

[Lei Zhang, 2015-04-01 22:15:00]

On 2015/04/01 21:55:03, lazyboy wrote:
> Orthogonal: why build doesn't complain? because we transitively end up pulling
> content_browser too?

That could be it. Or if you clobber your build dir, and carefully build targets
one at a time, you may be able to find some case where the build will fail.

[lazyboy, 2015-04-01 22:52:28]

lazyboy@chromium.org changed reviewers:
+ davidben@chromium.org

[lazyboy, 2015-04-01 22:52:29]

+davidben for components/browsing_data/DEPS change.

[davidben, 2015-04-01 23:12:19]

DEPS lgtm

[lazyboy, 2015-04-02 00:57:01]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2015-04-02 00:57:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
blundell@chromium.org, thestig@chromium.org, fsamuel@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1049423002/#ps100001 (title: "one more
dispcrepancy in build file fixed")

[commit-bot: I haz the power, 2015-04-02 00:57:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049423002/100001

[commit-bot: I haz the power, 2015-04-02 01:05:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-03 20:20:41]

Patchset 6 (id:??) landed as
https://crrev.com/14082d23ec62e040992a82a7e535d2c004874b8a
Cr-Commit-Position: refs/heads/master@{#323385}