Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10494012: Move mock notification observer header from content\test to content\public\test. This way we can en… (Closed)

Created:
8 years, 6 months ago by jam
Modified:
8 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, jochen+watch-content_chromium.org, dhollowa+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, dyu1, Raghu Simha, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Move mock notification observer header from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140245

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -92 lines) Patch
M chrome/browser/autofill/personal_data_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_change_registrar_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_notifier_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_set_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/thread_observer_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_netlog_observer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A + content/public/test/mock_notification_observer.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/test/mock_notification_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D content/test/notification_observer_mock.h View 1 chunk +0 lines, -29 lines 0 comments Download
D content/test/notification_observer_mock.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 6 months ago (2012-06-04 01:00:48 UTC) #1
Paweł Hajdan Jr.
8 years, 6 months ago (2012-06-04 16:53:28 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698