Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: sandbox/src/Wow64.cc

Issue 10493002: Revert 130716 - Use ScopedProcessInformation and other RAII types in sandbox. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sandbox/src/broker_services.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/src/wow64.h" 5 #include "sandbox/src/wow64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/win/scoped_process_information.h"
12 #include "base/win/windows_version.h" 11 #include "base/win/windows_version.h"
13 #include "sandbox/src/target_process.h" 12 #include "sandbox/src/target_process.h"
14 13
15 namespace { 14 namespace {
16 15
17 // Holds the information needed for the interception of NtMapViewOfSection on 16 // Holds the information needed for the interception of NtMapViewOfSection on
18 // 64 bits. 17 // 64 bits.
19 // Warning: do not modify this definition without changing also the code on the 18 // Warning: do not modify this definition without changing also the code on the
20 // 64 bit helper process. 19 // 64 bit helper process.
21 struct PatchInfo32 { 20 struct PatchInfo32 {
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 149
151 std::wstringstream command; 150 std::wstringstream command;
152 command << std::hex << std::showbase << L"\"" << path << 151 command << std::hex << std::showbase << L"\"" << path <<
153 L"wow_helper.exe\" " << child_->ProcessId() << " " << 152 L"wow_helper.exe\" " << child_->ProcessId() << " " <<
154 bit_cast<ULONG>(buffer); 153 bit_cast<ULONG>(buffer);
155 154
156 scoped_ptr_malloc<wchar_t> writable_command(_wcsdup(command.str().c_str())); 155 scoped_ptr_malloc<wchar_t> writable_command(_wcsdup(command.str().c_str()));
157 156
158 STARTUPINFO startup_info = {0}; 157 STARTUPINFO startup_info = {0};
159 startup_info.cb = sizeof(startup_info); 158 startup_info.cb = sizeof(startup_info);
160 base::win::ScopedProcessInformation process_info; 159 PROCESS_INFORMATION process_info;
161 if (!::CreateProcess(NULL, writable_command.get(), NULL, NULL, FALSE, 0, NULL, 160 if (!::CreateProcess(NULL, writable_command.get(), NULL, NULL, FALSE, 0, NULL,
162 NULL, &startup_info, process_info.Receive())) 161 NULL, &startup_info, &process_info))
163 return false; 162 return false;
164 163
165 DWORD reason = ::WaitForSingleObject(process_info.process_handle(), INFINITE); 164 DWORD reason = ::WaitForSingleObject(process_info.hProcess, INFINITE);
166 165
167 DWORD code; 166 DWORD code;
168 bool ok = 167 bool ok = ::GetExitCodeProcess(process_info.hProcess, &code) ? true : false;
169 ::GetExitCodeProcess(process_info.process_handle(), &code) ? true : false; 168
169 ::CloseHandle(process_info.hProcess);
170 ::CloseHandle(process_info.hThread);
170 171
171 if (WAIT_TIMEOUT == reason) 172 if (WAIT_TIMEOUT == reason)
172 return false; 173 return false;
173 174
174 return ok && (0 == code); 175 return ok && (0 == code);
175 } 176 }
176 177
177 // First we must wake up the child, then wait for dll loads on the child until 178 // First we must wake up the child, then wait for dll loads on the child until
178 // the one we care is loaded; at that point we must suspend the child again. 179 // the one we care is loaded; at that point we must suspend the child again.
179 bool Wow64::DllMapped() { 180 bool Wow64::DllMapped() {
(...skipping 30 matching lines...) Expand all
210 SIZE_T read; 211 SIZE_T read;
211 if (!::ReadProcessMemory(child_->Process(), ntdll_, &buffer, kBufferSize, 212 if (!::ReadProcessMemory(child_->Process(), ntdll_, &buffer, kBufferSize,
212 &read)) 213 &read))
213 return false; 214 return false;
214 if (kBufferSize != read) 215 if (kBufferSize != read)
215 return false; 216 return false;
216 return true; 217 return true;
217 } 218 }
218 219
219 } // namespace sandbox 220 } // namespace sandbox
OLDNEW
« no previous file with comments | « no previous file | sandbox/src/broker_services.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698