Issue 10492009: Move test headers from content\test to content\public\test. This way we can enforce that internal c…

Issue 10492009: Move test headers from content\test to content\public\test. This way we can enforce that internal c… (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, michaeln, creis+watch_chromium.org, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, ben+watch_chromium.org, brettw-cc_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, sadrul, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move test headers from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140256

Patch Set 1 #

Patch Set 2 : fix mac #

Patch Set 3 : fix mac #

Patch Set 4 : fix mac #

Patch Set 5 : fix mac #

Total comments: 8

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -183 lines)			Patch
M	ash/test/DEPS	View		1 chunk	+1 line, -0 lines	2 comments	Download
M	ash/test/test_shell_delegate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -1 line	2 comments	Download
M	chrome/renderer/safe_browsing/phishing_thumbnailer_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/appcache/chrome_appcache_service_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/browser_url_handler_impl_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/download_manager_impl_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/text_input_client_mac_unittest.mm	View	1 2 3 4	2 chunks	+2 lines, -2 lines	2 comments	Download
M	content/browser/site_instance_impl_unittest.cc	View		5 chunks	+9 lines, -5 lines	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/render_view_host_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_delegate_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/public/test/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	content/public/test/render_widget_browsertest.h	View		3 chunks	+8 lines, -4 lines	0 comments	Download
A +	content/public/test/test_browser_context.h	View		4 chunks	+11 lines, -10 lines	2 comments	Download
M	content/renderer/render_widget.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
D	content/test/render_widget_browsertest.h	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	content/test/render_widget_browsertest.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download
D	content/test/test_browser_context.h	View		1 chunk	+0 lines, -58 lines	0 comments	Download
M	content/test/test_browser_context.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	content/test/test_renderer_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM http://codereview.chromium.org/10492009/diff/12011/ash/test/DEPS File ash/test/DEPS (right): http://codereview.chromium.org/10492009/diff/12011/ash/test/DEPS#newcode3 ash/test/DEPS:3: "+content/test", nit: This should have a TODO to ...

8 years, 6 months ago (2012-06-05 09:47:23 UTC) #2

jam

8 years, 6 months ago (2012-06-05 15:57:54 UTC) #3

thanks for all the reviews!

http://codereview.chromium.org/10492009/diff/12011/ash/test/DEPS
File ash/test/DEPS (right):

http://codereview.chromium.org/10492009/diff/12011/ash/test/DEPS#newcode3
ash/test/DEPS:3: "+content/test",
On 2012/06/05 09:47:24, Paweł Hajdan Jr. wrote:
> nit: This should have a TODO to remove it, right?

I've removed this in a followup

http://codereview.chromium.org/10492009/diff/12011/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10492009/diff/12011/chrome/chrome_tests.gypi#n...
chrome/chrome_tests.gypi:3021:
'../content/public/test/render_widget_browsertest.h',
On 2012/06/05 09:47:24, Paweł Hajdan Jr. wrote:
> nit: Wasn't the convention to have public header files only in content
targets?
> Up to you of course.

I think these files need to be here since we only have one browser_test target?
Once I have content_browsertest I'll move these out

http://codereview.chromium.org/10492009/diff/12011/content/browser/renderer_h...
File content/browser/renderer_host/text_input_client_mac_unittest.mm (right):

http://codereview.chromium.org/10492009/diff/12011/content/browser/renderer_h...
content/browser/renderer_host/text_input_client_mac_unittest.mm:16: #include
"content/public/test//test_browser_context.h"
On 2012/06/05 09:47:24, Paweł Hajdan Jr. wrote:
> nit: Double slash.

fixed in followup

http://codereview.chromium.org/10492009/diff/12011/content/public/test/test_b...
File content/public/test/test_browser_context.h (right):

http://codereview.chromium.org/10492009/diff/12011/content/public/test/test_b...
content/public/test/test_browser_context.h:57: }
On 2012/06/05 09:47:24, Paweł Hajdan Jr. wrote:
> nit:  // namespace content

will fix in a followup

Expand Messages | Collapse Messages