Implement the windows policy provider based on the AsyncPolicyLoader.

Implement the windows policy provider based on the AsyncPolicyLoader.

BUG=130918
TEST=windows policy still works, unit_tests green

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140770

[Joao da Silva, 2012-06-03 15:07:35]

CL 4/5: refactor the win provider.

This still needs manual testing.

[Mattias Nissler (ping if slow), 2012-06-04 09:29:41]

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win.cc (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.cc:217:
user_policy_watcher_failed_(false),
the failed_ fields are no longer used AFAICS

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win.h (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.h:24: const PolicyDefinitionList*
policy_list);
fits previous line.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.h:35: // Updates the watchers and
schedules the reload task if appropriate.
No longer schedules a task.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win_unittest.cc:217: class
WinPolicyLoaderTest : public PolicyTestBase {
same comment as for mac regarding clashing test names

[Joao da Silva, 2012-06-06 13:05:24]

Please have another look. This is the last CL of the refactor. I've manually
verified that it still works on Windows: reacts to policy changes, and refresh
policies also works.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win.cc (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.cc:217:
user_policy_watcher_failed_(false),
On 2012/06/04 09:29:41, Mattias Nissler wrote:
> the failed_ fields are no longer used AFAICS

They're used in SetupWatches() to stop trying to install the watches if it
failed before.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win.h (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.h:24: const PolicyDefinitionList*
policy_list);
On 2012/06/04 09:29:41, Mattias Nissler wrote:
> fits previous line.

Done.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win.h:35: // Updates the watchers and
schedules the reload task if appropriate.
On 2012/06/04 09:29:41, Mattias Nissler wrote:
> No longer schedules a task.

Done.

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

http://codereview.chromium.org/10491013/diff/11002/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win_unittest.cc:217: class
WinPolicyLoaderTest : public PolicyTestBase {
On 2012/06/04 09:29:41, Mattias Nissler wrote:
> same comment as for mac regarding clashing test names

Done.

[Mattias Nissler (ping if slow), 2012-06-06 13:24:52]

LGTM, but please consider my suggestion.

http://codereview.chromium.org/10491013/diff/23001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

http://codereview.chromium.org/10491013/diff/23001/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win_unittest.cc:241: AsyncPolicyProvider
provider(&test_policy_definitions::kList, loader.Pass());
Same as noted on the other CL: We actually don't need a provider to test
PolicyLoaderWin. In this case, there's only one simple test case, maybe it's
worth removing the provider here?

[Joao da Silva, 2012-06-06 14:47:24]

http://codereview.chromium.org/10491013/diff/23001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_loader_win_unittest.cc (right):

http://codereview.chromium.org/10491013/diff/23001/chrome/browser/policy/poli...
chrome/browser/policy/policy_loader_win_unittest.cc:241: AsyncPolicyProvider
provider(&test_policy_definitions::kList, loader.Pass());
On 2012/06/06 13:24:52, Mattias Nissler wrote:
> Same as noted on the other CL: We actually don't need a provider to test
> PolicyLoaderWin. In this case, there's only one simple test case, maybe it's
> worth removing the provider here?

Done.

[commit-bot: I haz the power, 2012-06-06 14:48:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10491013/27005

[commit-bot: I haz the power, 2012-06-06 15:51:52]

Change committed as 140770