Issue 10491006: Remove host target of ICU on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10491006: Remove host target of ICU on Android (Closed)

Created:
8 years, 6 months ago by Xianzhu

Modified:
8 years, 6 months ago

Reviewers:
abarth-chromium

CC:
Hao Zheng

Base URL:
http://git.chromium.org/chromium/deps/icu46.git@master

Visibility:
Public.

More Reviews

Description

Remove host target of ICU on Android Previously host target of ICU is required on Android because ImageDiff depends on WTF and in turn on icu. WTF dependency of ImageDiff has been removed in https://bugs.webkit.org/show_bug.cgi?id=88147. BUG=none TEST=none

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -18 lines)			Patch
	M	icu.gyp	View		3 chunks	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

8 years, 6 months ago (2012-06-02 01:00:51 UTC) #3

On 2012/06/01 23:44:10, abarth wrote:
> ok.  lgtm

Thanks.

Submitted manually as r140144 as the CQ seems to ignore this CL (I checked
'Commit' 1 hour ago and nothing happened).

Will roll icu after the WebKit CL is landed.

Expand Messages | Collapse Messages