Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3056)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1048463004: PlzNavigate: track pending commits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 32f102dfbdf6e5f0414c9aeaf0030037c9590328..db9d9fcf64a4336dfb04f327ca5ac1bdcb1fdbbe 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -2660,11 +2660,11 @@ TEST_F(WebContentsImplTest, ActiveContentsCountNavigate) {
std::string());
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation)) {
- contents->GetMainFrame()->SendBeforeUnloadACK(true);
+ contents->GetMainFrame()->PrepareForCommit();
clamy 2015/03/30 12:50:57 Decoupling the CommitPendingNavigation in two was
carlosk 2015/03/31 13:01:32 To make sure I understand what you mean: you are e
}
EXPECT_TRUE(contents->cross_navigation_pending());
EXPECT_EQ(1u, instance->GetRelatedActiveContentsCount());
- contents->CommitPendingNavigation();
+ contents->GetPendingMainFrame()->SendNavigate(0, kUrl);
EXPECT_EQ(1u, instance->GetRelatedActiveContentsCount());
contents.reset();

Powered by Google App Engine
This is Rietveld 408576698