Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1048463004: PlzNavigate: track pending commits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 89eeef69f9d549dc85a644eb8021a57176ce91d2..44d3c537cd8e2a6d12c92f419a6b66506530f624 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -389,9 +389,11 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// Called (possibly several times) during a navigation to select or create an
// appropriate RenderFrameHost for the provided URL. The returned pointer will
// be for the current or the speculative RenderFrameHost and the instance is
- // owned by this manager.
+ // owned by this manager. ¬for_commit¬ is true if it is the final call in the
nasko 2015/03/30 22:35:22 nit: The characters around "for_commit" aren't som
+ // navigation, and the renderer selected will commit the navigation.
RenderFrameHostImpl* GetFrameHostForNavigation(
- const NavigationRequest& request);
+ const NavigationRequest& request,
+ bool for_commit);
// PlzNavigate
// Clean up any state for any ongoing navigation.
@@ -621,7 +623,8 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// Whether a navigation requiring different RenderFrameHosts is pending. This
// is either for cross-site requests or when required for the process type
// (like WebUI).
- // PlzNavigate: |cross_navigation_pending_| is not used for browser-side
+ // PlzNavigate: |cross_navigation_pending_| is used to signal that the
+ // speculative_render_frame_host_ is in the process of committing the
// navigation.
bool cross_navigation_pending_;

Powered by Google App Engine
This is Rietveld 408576698