Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1048413002: Support of specify local prebuilt network service apptests file. (Closed)

Created:
5 years, 8 months ago by haltonhuo
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support of specify local prebuilt network service apptests file. Same as https://codereview.chromium.org/983143003, we need specify network_service_apptests.mojo as well. BUG=472609 Committed: https://crrev.com/78d4a7e127b51a315bbb0b26aadd7e601a50e50f Cr-Commit-Position: refs/heads/master@{#323656}

Patch Set 1 #

Patch Set 2 : Add BUG info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/module_args/mojo.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
haltonhuo
The mojo counter-part CL is https://codereview.chromium.org/1056503002/
5 years, 8 months ago (2015-04-01 12:44:06 UTC) #2
qsr
lgtm
5 years, 8 months ago (2015-04-02 09:00:28 UTC) #3
cjhopman
lgtm
5 years, 8 months ago (2015-04-02 16:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048413002/20001
5 years, 8 months ago (2015-04-03 00:54:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 07:42:24 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:33:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78d4a7e127b51a315bbb0b26aadd7e601a50e50f
Cr-Commit-Position: refs/heads/master@{#323656}

Powered by Google App Engine
This is Rietveld 408576698