Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048373003: CancelableTaskTracker::PostDelayedTask() support (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima
Modified:
3 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CancelableTaskTracker::PostDelayedTask() support Media like stuffs, e.g. MIDI, requires a precise scheduler that allows task cancellation. CancelableTaskTracker is a class to manage cancelable tasks, but did not support delayed task. This patch adds PostDelayedTask() to CancelableTaskTracker, and add PostDelayedTaskAndReply interface to TaskRunner to implement it. BUG=na

Patch Set 1 #

Total comments: 4

Patch Set 2 : tzik review #

Patch Set 3 : more const TimeDelta& #

Patch Set 4 : add test #

Total comments: 2

Patch Set 5 : remove unnecessary base:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -30 lines) Patch
M base/task/cancelable_task_tracker.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M base/task/cancelable_task_tracker.cc View 1 2 3 4 4 chunks +48 lines, -28 lines 0 comments Download
M base/task/cancelable_task_tracker_unittest.cc View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M base/task_runner.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M base/task_runner.cc View 1 2 3 4 chunks +20 lines, -1 line 0 comments Download
M base/threading/post_task_and_reply_impl.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M base/threading/post_task_and_reply_impl.cc View 1 2 3 2 chunks +17 lines, -0 lines 0 comments Download
M base/threading/worker_pool.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Takashi Toyoshima
Hi Nico, I want to use CancelableTaskTracker, but it does not support delayed task that ...
5 years, 8 months ago (2015-04-01 05:59:06 UTC) #2
tzik
https://codereview.chromium.org/1048373003/diff/1/base/task/cancelable_task_tracker.cc File base/task/cancelable_task_tracker.cc (right): https://codereview.chromium.org/1048373003/diff/1/base/task/cancelable_task_tracker.cc#newcode180 base/task/cancelable_task_tracker.cc:180: DCHECK(base::MessageLoopProxy::current().get()); Can we use ThreadTaskRunnerHandle::Get() here? https://codereview.chromium.org/1048373003/diff/1/base/task/cancelable_task_tracker.h File base/task/cancelable_task_tracker.h ...
5 years, 8 months ago (2015-04-01 06:17:53 UTC) #4
Takashi Toyoshima
https://codereview.chromium.org/1048373003/diff/1/base/task/cancelable_task_tracker.cc File base/task/cancelable_task_tracker.cc (right): https://codereview.chromium.org/1048373003/diff/1/base/task/cancelable_task_tracker.cc#newcode180 base/task/cancelable_task_tracker.cc:180: DCHECK(base::MessageLoopProxy::current().get()); On 2015/04/01 06:17:53, tzik wrote: > Can we ...
5 years, 8 months ago (2015-04-01 06:51:32 UTC) #5
tzik
non-owner LGTM https://codereview.chromium.org/1048373003/diff/60001/base/task/cancelable_task_tracker.cc File base/task/cancelable_task_tracker.cc (right): https://codereview.chromium.org/1048373003/diff/60001/base/task/cancelable_task_tracker.cc#newcode195 base/task/cancelable_task_tracker.cc:195: base::Owned(flag), Can we remove "base::"?
5 years, 8 months ago (2015-04-02 02:18:07 UTC) #6
Takashi Toyoshima
https://codereview.chromium.org/1048373003/diff/60001/base/task/cancelable_task_tracker.cc File base/task/cancelable_task_tracker.cc (right): https://codereview.chromium.org/1048373003/diff/60001/base/task/cancelable_task_tracker.cc#newcode195 base/task/cancelable_task_tracker.cc:195: base::Owned(flag), On 2015/04/02 02:18:07, tzik wrote: > Can we ...
5 years, 8 months ago (2015-04-02 06:04:46 UTC) #7
Takashi Toyoshima
ping (nico)
5 years, 7 months ago (2015-05-25 04:25:21 UTC) #8
eduvinamaldonado76
4 years, 1 month ago (2016-10-31 05:32:15 UTC) #10 
lgtm

Powered by Google App Engine
This is Rietveld 408576698