Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10483003: Move the rest of the content\test headers that are used by embedders to content\public\test. This w… (Closed)

Created:
8 years, 6 months ago by jam
Modified:
8 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, ncarter (slow), aboxhall+watch_chromium.org, Ilya Sherman, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Andrei, tim (not reviewing), Avi (use Gerrit), jennb, creis+watch_chromium.org, dtseng+watch_chromium.org, jochen+watch-content_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, jianli, yuzo+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, hashimoto+watch_chromium.org, tfarina, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, Satish, dyu1, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move the rest of the content\test headers that are used by embedders to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140287

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -772 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_download_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/cws_intents_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_management_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/ubertoken_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/mock_url_fetcher_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/gaia/oauth2_revocation_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/intent_injector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/google_one_shot_remote_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/public/test/test_renderer_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/test/test_url_fetcher_factory.h View 2 chunks +3 lines, -3 lines 1 comment Download
A + content/public/test/unittest_test_suite.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + content/public/test/web_contents_tester.h View 5 chunks +32 lines, -37 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +3 lines, -2 lines 1 comment Download
D content/test/test_renderer_host.h View 1 chunk +0 lines, -187 lines 0 comments Download
M content/test/test_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/test/test_url_fetcher_factory.h View 1 chunk +0 lines, -293 lines 0 comments Download
M content/test/test_url_fetcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/test/unittest_test_suite.h View 1 chunk +0 lines, -38 lines 0 comments Download
M content/test/unittest_test_suite.cc View 2 chunks +5 lines, -1 line 0 comments Download
D content/test/web_contents_tester.h View 1 chunk +0 lines, -123 lines 0 comments Download
M content/test/web_contents_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
I'll tighten DEPS to remove content\test in a followup change.
8 years, 6 months ago (2012-06-04 06:53:10 UTC) #1
Paweł Hajdan Jr.
8 years, 6 months ago (2012-06-18 15:29:16 UTC) #2 
LGTM with nits.

http://codereview.chromium.org/10483003/diff/24001/content/public/test/test_u...
File content/public/test/test_url_fetcher_factory.h (right):

http://codereview.chromium.org/10483003/diff/24001/content/public/test/test_u...
content/public/test/test_url_fetcher_factory.h:5: #ifndef
CONTENT_PUBLIC_TEST_TEST_URL_FETCHER_FACTORY_H_
nit: Shouldn't contents of this header be in the content namespace then?

http://codereview.chromium.org/10483003/diff/24001/content/test/run_all_unitt...
File content/test/run_all_unittests.cc (right):

http://codereview.chromium.org/10483003/diff/24001/content/test/run_all_unitt...
content/test/run_all_unittests.cc:6: #include
"content/public/test/unittest_test_suite.h"
nit: Please sort.

Powered by Google App Engine
This is Rietveld 408576698