Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 10480002: Implements metrics for destination search. (Closed)

Created:
8 years, 6 months ago by Robert Toscano
Modified:
8 years, 6 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implements metrics for destination search. BUG=128275 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -3 lines) Patch
A chrome/browser/resources/print_preview/metrics.js View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 5 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview_utils.js View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 7 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Toscano
Added metrics for destination search widget. PTAL.
8 years, 6 months ago (2012-06-01 18:38:13 UTC) #1
Albert Bodenhamer
lgtm
8 years, 6 months ago (2012-06-03 02:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@google.com/10480002/1
8 years, 6 months ago (2012-06-03 17:00:43 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-03 20:06:21 UTC) #4
Change committed as 140240

Powered by Google App Engine
This is Rietveld 408576698