Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: content/browser/site_instance_impl_unittest.cc

Issue 10479023: Simplify how Content*Client interfaces are created. Instead of depending on the embedder to know wh… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: remove unused function declaration Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl_unittest.cc
===================================================================
--- content/browser/site_instance_impl_unittest.cc (revision 140381)
+++ content/browser/site_instance_impl_unittest.cc (working copy)
@@ -8,7 +8,6 @@
#include "content/browser/browser_thread_impl.h"
#include "content/browser/browsing_instance.h"
#include "content/browser/child_process_security_policy_impl.h"
-#include "content/browser/mock_content_browser_client.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/test_render_view_host.h"
@@ -22,6 +21,7 @@
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread.h"
+#include "content/test/test_content_browser_client.h"
#include "content/test/test_content_client.h"
#include "googleurl/src/url_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -81,7 +81,7 @@
};
class SiteInstanceTestBrowserClient :
- public content::MockContentBrowserClient {
+ public content::TestContentBrowserClient {
public:
SiteInstanceTestBrowserClient()
: privileged_process_id_(-1) {
@@ -127,13 +127,13 @@
old_client_ = content::GetContentClient();
old_browser_client_ = content::GetContentClient()->browser();
content::SetContentClient(&client_);
- content::GetContentClient()->set_browser(&browser_client_);
+ content::GetContentClient()->set_browser_for_testing(&browser_client_);
url_util::AddStandardScheme(kPrivilegedScheme);
url_util::AddStandardScheme(chrome::kChromeUIScheme);
}
virtual void TearDown() {
- content::GetContentClient()->set_browser(old_browser_client_);
+ content::GetContentClient()->set_browser_for_testing(old_browser_client_);
content::SetContentClient(old_client_);
MessageLoop::current()->RunAllPending();
message_loop_.RunAllPending();

Powered by Google App Engine
This is Rietveld 408576698