Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2571)

Unified Diff: chrome_frame/test/chrome_frame_automation_mock.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: phajdan feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/perf/rendering/throughput_tests.cc ('k') | chrome_frame/test/chrome_frame_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_automation_mock.cc
diff --git a/chrome_frame/test/chrome_frame_automation_mock.cc b/chrome_frame/test/chrome_frame_automation_mock.cc
index 8b553a5bf3cd04ad691a8c7c854dcfe0f2484d70..d3077124943dcbfba2405c6e509bbf4f2c838a19 100644
--- a/chrome_frame/test/chrome_frame_automation_mock.cc
+++ b/chrome_frame/test/chrome_frame_automation_mock.cc
@@ -16,7 +16,8 @@ TEST(ChromeFrame, Launch) {
loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);
mock_launch.Navigate("about:blank");
- loop.RunWithDispatcher(NULL);
+ base::RunLoop run_loop(NULL);
+ run_loop.Run();
EXPECT_TRUE(mock_launch.launch_result());
}
@@ -28,7 +29,8 @@ TEST(ChromeFrame, Navigate) {
loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);
mock_navigate.NavigateRelativeFile(L"postmessage_basic_frame.html");
- loop.RunWithDispatcher(NULL);
+ base::RunLoop run_loop(NULL);
+ run_loop.Run();
EXPECT_FALSE(mock_navigate.navigation_result());
}
@@ -40,7 +42,8 @@ TEST(ChromeFrame, PostMessage) {
loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);
mock_postmessage.NavigateRelativeFile(L"postmessage_basic_frame.html");
- loop.RunWithDispatcher(NULL);
+ base::RunLoop run_loop(NULL);
+ run_loop.Run();
EXPECT_FALSE(mock_postmessage.postmessage_result());
}
@@ -52,7 +55,8 @@ TEST(ChromeFrame, RequestStart) {
loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);
mock_request_start.NavigateRelative(L"postmessage_basic_frame.html");
- loop.RunWithDispatcher(NULL);
+ base::RunLoop run_loop(NULL);
+ run_loop.Run();
EXPECT_TRUE(mock_request_start.request_start_result());
}
« no previous file with comments | « chrome/test/perf/rendering/throughput_tests.cc ('k') | chrome_frame/test/chrome_frame_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698