chrome/browser/ui/views/simple_message_box_views.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: phajdan feedback Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu_browsertest_util.cc ('k') | chrome/browser/ui/views/uninstall_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index 805c6b523828d37f506ac080b019b79e81d4ee7d..a3998857766e07ef961068939ae0704c4703ba60 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -8,6 +8,7 @@

#include "base/compiler_specific.h"

#include "base/memory/ref_counted.h"

#include "base/message_loop.h"

+#include "base/run_loop.h"

#include "chrome/browser/browser_process.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -179,7 +180,8 @@ MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,

#else

{

MessageLoop::ScopedNestableTaskAllower allow(MessageLoopForUI::current());

- MessageLoopForUI::current()->RunWithDispatcher(dialog);

+ base::RunLoop run_loop(dialog);

+ run_loop.Run();

}

#endif

return dialog->result();