Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: ash/accelerators/nested_dispatcher_controller.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: phajdan feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/drag_drop/drag_drop_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/accelerators/nested_dispatcher_controller.cc
diff --git a/ash/accelerators/nested_dispatcher_controller.cc b/ash/accelerators/nested_dispatcher_controller.cc
index 5daeca2e8973a531f66d2519d4fa586267c166c7..45ad0e44a1eba22f5a016126b9c7a7403b075f57 100644
--- a/ash/accelerators/nested_dispatcher_controller.cc
+++ b/ash/accelerators/nested_dispatcher_controller.cc
@@ -6,6 +6,7 @@
#include "ash/accelerators/accelerator_dispatcher.h"
#include "ash/shell.h"
+#include "base/run_loop.h"
namespace ash {
@@ -25,7 +26,10 @@ void NestedDispatcherController::RunWithDispatcher(
AcceleratorDispatcher dispatcher(nested_dispatcher, associated_window);
- loop->RunWithDispatcher(&dispatcher);
+ // TODO(jbates) crbug.com/134753 Find quitters of this RunLoop and have them
+ // use run_loop.QuitClosure().
+ base::RunLoop run_loop(&dispatcher);
+ run_loop.Run();
loop->SetNestableTasksAllowed(did_allow_task_nesting);
}
« no previous file with comments | « no previous file | ash/drag_drop/drag_drop_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698