chrome/browser/referrer_policy_browsertest.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/referrer_policy_browsertest.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback, compile errors Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_pump_android.cc ('K') | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/tab_contents/render_view_context_menu_browsertest.cc » ('j') | chrome/test/base/ui_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/referrer_policy_browsertest.cc

diff --git a/chrome/browser/referrer_policy_browsertest.cc b/chrome/browser/referrer_policy_browsertest.cc

index df69f972d536b4ff369fb92e72fb1066e4dbfd2d..a25b5aecba16357a77a0f2d259af566c094252d6 100644

--- a/chrome/browser/referrer_policy_browsertest.cc

+++ b/chrome/browser/referrer_policy_browsertest.cc

@@ -254,8 +254,7 @@ IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, HttpsMiddleClickTargetBlankOrigin) {

// Context menu, from HTTP to HTTP.

IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_ContextMenuOrigin) {

ContextMenuNotificationObserver context_menu_observer(

- IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,

- chrome::NOTIFICATION_TAB_ADDED);

+ IDC_CONTENT_CONTEXT_OPENLINKNEWTAB);

RunReferrerTest("origin", false, false, false, true,

WebKit::WebMouseEvent::ButtonRight,

EXPECT_ORIGIN_AS_REFERRER);

@@ -264,8 +263,7 @@ IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_ContextMenuOrigin) {

// Context menu, from HTTPS to HTTP.

IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_HttpsContextMenuOrigin) {

ContextMenuNotificationObserver context_menu_observer(

- IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,

- chrome::NOTIFICATION_TAB_ADDED);

+ IDC_CONTENT_CONTEXT_OPENLINKNEWTAB);

RunReferrerTest("origin", true, false, false, true,

WebKit::WebMouseEvent::ButtonRight,

EXPECT_ORIGIN_AS_REFERRER);

@@ -351,8 +349,7 @@ IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest,

// Context menu, from HTTP to HTTP via server redirect.

IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_ContextMenuRedirect) {

ContextMenuNotificationObserver context_menu_observer(

- IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,

- chrome::NOTIFICATION_TAB_ADDED);

+ IDC_CONTENT_CONTEXT_OPENLINKNEWTAB);

RunReferrerTest("origin", false, false, true, true,

WebKit::WebMouseEvent::ButtonRight,

EXPECT_ORIGIN_AS_REFERRER);

@@ -361,8 +358,7 @@ IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_ContextMenuRedirect) {

// Context menu, from HTTPS to HTTP via server redirect.

IN_PROC_BROWSER_TEST_F(ReferrerPolicyTest, MAYBE_HttpsContextMenuRedirect) {

ContextMenuNotificationObserver context_menu_observer(

- IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,

- chrome::NOTIFICATION_TAB_ADDED);

+ IDC_CONTENT_CONTEXT_OPENLINKNEWTAB);

RunReferrerTest("origin", true, false, true, true,

WebKit::WebMouseEvent::ButtonRight,

EXPECT_ORIGIN_AS_REFERRER);