chrome/test/base/test_web_dialog_observer.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/test_web_dialog_observer.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: change Quit to QuitNow in places where it makes sense Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/test_web_dialog_observer.cc

diff --git a/chrome/test/base/test_web_dialog_observer.cc b/chrome/test/base/test_web_dialog_observer.cc

index 11ba4960d6a65eb98a8710f98491da03a11c8462..274250df68eeaa3b37874984669a646b02766134 100644

--- a/chrome/test/base/test_web_dialog_observer.cc

+++ b/chrome/test/base/test_web_dialog_observer.cc

@@ -42,7 +42,7 @@ void TestWebDialogObserver::Observe(

// If the message loop is running stop it.

if (running_) {

running_ = false;

- MessageLoopForUI::current()->Quit();

+ MessageLoopForUI::current()->QuitNow();

}

break;

default:

« no previous file with comments | « chrome/test/base/bookmark_load_observer.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | chrome/test/base/ui_test_utils.cc » ('J')