Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/test/perf/rendering/throughput_tests.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android compile Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/perf/rendering/throughput_tests.cc
diff --git a/chrome/test/perf/rendering/throughput_tests.cc b/chrome/test/perf/rendering/throughput_tests.cc
index 606fb940c6ac9d8e8cdf9fced8abe3ddc9f20cab..d97829dc581319f68641be72771f7d80be9a8ba7 100644
--- a/chrome/test/perf/rendering/throughput_tests.cc
+++ b/chrome/test/perf/rendering/throughput_tests.cc
@@ -195,11 +195,11 @@ class ThroughputTest : public BrowserPerfTest {
}
void Wait(int ms) {
+ MessageLoop::RunLoop run_loop;
MessageLoop::current()->PostDelayedTask(
- FROM_HERE,
- MessageLoop::QuitClosure(),
+ FROM_HERE, run_loop.StopClosure(),
base::TimeDelta::FromMilliseconds(ms));
- ui_test_utils::RunMessageLoop();
+ ui_test_utils::RunRunLoop(run_loop.AsWeakPtr());
}
// Take snapshot of the current tab, encode it as PNG, and save to a SkBitmap.

Powered by Google App Engine
This is Rietveld 408576698