chrome/browser/crash_recovery_browsertest.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_recovery_browsertest.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win_shared build Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_loop_unittest.cc ('K') | « base/message_pump_android.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | chrome/browser/extensions/extension_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/crash_recovery_browsertest.cc

diff --git a/chrome/browser/crash_recovery_browsertest.cc b/chrome/browser/crash_recovery_browsertest.cc

index c4843532f40be73fc07a9d7d981b14a4cf9ff8f6..0554cc0e6d74072d93e1d833c844b94a46eac89b 100644

--- a/chrome/browser/crash_recovery_browsertest.cc

+++ b/chrome/browser/crash_recovery_browsertest.cc

@@ -75,6 +75,8 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, LoadInNewTab) {

string16 title_before_crash;

string16 title_after_crash;

+ // Wait for MessageLoop to go idle to make sure title is set.

+ ui_test_utils::RunAllPendingInMessageLoop();

ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),

&title_before_crash));

SimulateRendererCrash(browser());

@@ -84,6 +86,9 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, LoadInNewTab) {

&browser()->GetActiveWebContents()->GetController()));

browser()->Reload(CURRENT_TAB);

observer.Wait();

+ // Wait for MessageLoop to go idle to make sure title is set.

+ ui_test_utils::RunAllPendingInMessageLoop();

ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),

&title_after_crash));

EXPECT_EQ(title_before_crash, title_after_crash);