chrome/test/perf/rendering/throughput_tests.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/perf/rendering/throughput_tests.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added printfs to debug timeout which doesn't happen locally Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/perf/rendering/throughput_tests.cc

diff --git a/chrome/test/perf/rendering/throughput_tests.cc b/chrome/test/perf/rendering/throughput_tests.cc

index 3c6632041c478f8e9e60bf3dc90e79e25322275b..1090dc271fd4c88ff7adfa56667e09d5cbfe4267 100644

--- a/chrome/test/perf/rendering/throughput_tests.cc

+++ b/chrome/test/perf/rendering/throughput_tests.cc

@@ -195,7 +195,7 @@ class ThroughputTest : public BrowserPerfTest {

void Wait(int ms) {

MessageLoop::current()->PostDelayedTask(

FROM_HERE,

- MessageLoop::QuitClosure(),

+ MessageLoop::QuitNowClosure(),

base::TimeDelta::FromMilliseconds(ms));

ui_test_utils::RunMessageLoop();

}

« chrome/test/base/ui_test_utils.cc ('K') | « chrome/test/base/ui_test_utils.cc ('k') | content/test/test_navigation_observer.cc » ('j') | content/test/test_navigation_observer.cc » ('J')