chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added printfs to debug timeout which doesn't happen locally Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc ('K') | « chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | chrome/test/base/ui_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

index 9c2a45c4105ab2b8db362c4b5894bbf2f06b8b46..f424e80cd4b9d6e3bd2513428a4b20133ee37b28 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

@@ -247,6 +247,9 @@ IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DeleteSourceDetached) {

ASSERT_TRUE(ui_test_utils::SendMouseEventsSync(

ui_controls::LEFT, ui_controls::UP));

+ // Wait for the effects of the mouse event to settle.

+ ui_test_utils::RunAllPendingInMessageLoop();

// Releasing the mouse should destroy the existing browser and create a new

// one.

ASSERT_EQ(1u, BrowserList::size());