Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

ui/views/focus/focus_manager_unittest_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/focus/focus_manager.h"
 
+#include "base/memory/scoped_ptr.h"
+#include "base/run_loop.h"
 #include "base/utf_string_conversions.h"
 #include "ui/views/controls/button/text_button.h"
 #include "ui/views/focus/accelerator_handler.h"
 #include "ui/views/focus/focus_manager_test.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
 namespace {
 
@@ skipping 191 matching lines @@
   MessageTrackingView* mtv = new MessageTrackingView();
   mtv->AddAccelerator(ui::Accelerator(ui::VKEY_0, ui::EF_NONE));
   mtv->AddAccelerator(ui::Accelerator(ui::VKEY_1, ui::EF_NONE));
   GetContentsView()->AddChildView(mtv);
   focus_manager->SetFocusedView(mtv);
 
   // First send a non-accelerator key sequence.
   PostKeyDown(ui::VKEY_9);
   PostKeyUp(ui::VKEY_9);
   AcceleratorHandler accelerator_handler;
-  MessageLoopForUI::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
-  MessageLoopForUI::current()->RunWithDispatcher(&accelerator_handler);
+  scoped_ptr<base::RunLoop> run_loop(new base::RunLoop(&accelerator_handler));
+  run_loop->RunUntilIdle();
   // Make sure we get a key-up and key-down.
   ASSERT_EQ(1U, mtv->keys_pressed().size());
   EXPECT_EQ(ui::VKEY_9, mtv->keys_pressed()[0]);
   ASSERT_EQ(1U, mtv->keys_released().size());
   EXPECT_EQ(ui::VKEY_9, mtv->keys_released()[0]);
   EXPECT_FALSE(mtv->accelerator_pressed());
   mtv->Reset();
 
   // Same thing with repeat and more than one key at once.
   PostKeyDown(ui::VKEY_9);
   PostKeyDown(ui::VKEY_9);
   PostKeyDown(ui::VKEY_8);
   PostKeyDown(ui::VKEY_9);
   PostKeyDown(ui::VKEY_7);
   PostKeyUp(ui::VKEY_9);
   PostKeyUp(ui::VKEY_7);
   PostKeyUp(ui::VKEY_8);
-  MessageLoopForUI::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
-  MessageLoopForUI::current()->RunWithDispatcher(&accelerator_handler);
+  run_loop.reset(new base::RunLoop(&accelerator_handler));
+  run_loop->RunUntilIdle();
   // Make sure we get a key-up and key-down.
   ASSERT_EQ(5U, mtv->keys_pressed().size());
   EXPECT_EQ(ui::VKEY_9, mtv->keys_pressed()[0]);
   EXPECT_EQ(ui::VKEY_9, mtv->keys_pressed()[1]);
   EXPECT_EQ(ui::VKEY_8, mtv->keys_pressed()[2]);
   EXPECT_EQ(ui::VKEY_9, mtv->keys_pressed()[3]);
   EXPECT_EQ(ui::VKEY_7, mtv->keys_pressed()[4]);
   ASSERT_EQ(3U, mtv->keys_released().size());
   EXPECT_EQ(ui::VKEY_9, mtv->keys_released()[0]);
   EXPECT_EQ(ui::VKEY_7, mtv->keys_released()[1]);
   EXPECT_EQ(ui::VKEY_8, mtv->keys_released()[2]);
   EXPECT_FALSE(mtv->accelerator_pressed());
   mtv->Reset();
 
   // Now send an accelerator key sequence.
   PostKeyDown(ui::VKEY_0);
   PostKeyUp(ui::VKEY_0);
-  MessageLoopForUI::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
-  MessageLoopForUI::current()->RunWithDispatcher(&accelerator_handler);
+  run_loop.reset(new base::RunLoop(&accelerator_handler));
+  run_loop->RunUntilIdle();
   EXPECT_TRUE(mtv->keys_pressed().empty());
   EXPECT_TRUE(mtv->keys_released().empty());
   EXPECT_TRUE(mtv->accelerator_pressed());
   mtv->Reset();
 
   // Same thing with repeat and more than one key at once.
   PostKeyDown(ui::VKEY_0);
   PostKeyDown(ui::VKEY_1);
   PostKeyDown(ui::VKEY_1);
   PostKeyDown(ui::VKEY_0);
   PostKeyDown(ui::VKEY_0);
   PostKeyUp(ui::VKEY_1);
   PostKeyUp(ui::VKEY_0);
-  MessageLoopForUI::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
-  MessageLoopForUI::current()->RunWithDispatcher(&accelerator_handler);
+  run_loop.reset(new base::RunLoop(&accelerator_handler));
+  run_loop->RunUntilIdle();
   EXPECT_TRUE(mtv->keys_pressed().empty());
   EXPECT_TRUE(mtv->keys_released().empty());
   EXPECT_TRUE(mtv->accelerator_pressed());
   mtv->Reset();
 }
 
 }  // namespace views