chrome/test/base/bookmark_load_observer.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/base/bookmark_load_observer.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback, compile errors Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/base/bookmark_load_observer.h"	5 #include "chrome/test/base/bookmark_load_observer.h"

6	6

7 #include "base/message_loop.h"	7 #include "chrome/test/base/ui_test_utils.h"

8	8

9 BookmarkLoadObserver::BookmarkLoadObserver() {}	9 BookmarkLoadObserver::BookmarkLoadObserver(

	10 const base::WeakPtr<base::RunLoop>& run_loop)

	11 : run_loop_(run_loop) {}

10	12

11 BookmarkLoadObserver::~BookmarkLoadObserver() {}	13 BookmarkLoadObserver::~BookmarkLoadObserver() {}

12	14

13 void BookmarkLoadObserver::Loaded(BookmarkModel* model, bool ids_reassigned) {	15 void BookmarkLoadObserver::Loaded(BookmarkModel* model, bool ids_reassigned) {

14 MessageLoop::current()->Quit();	16 ui_test_utils::QuitThisRunLoop(run_loop_);

15 }	17 }

OLD	NEW

« base/message_pump_android.cc ('K') | « chrome/test/base/bookmark_load_observer.h ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | chrome/test/base/ui_test_utils.cc » ('J')