Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 10477022: Merge 118891 - REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled (Closed)

Created:
8 years, 6 months ago by yosin_UTC9
Modified:
8 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118891 - REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled https://bugs.webkit.org/show_bug.cgi?id=87719 Reviewed by Kent Tamura. Source/WebCore: This patch added checking of "option" element for CSS pseudo class :enabled as same as :disabled to selector checker. Before r111497, it was done by using isFormControlElement. After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement. Test: fast/form/select/optgroup-rendering.html * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same as PseudoDisabled in PseudoEnabled case. LayoutTests: * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled. * platform/chromium/test_expectations.txt: Update comment. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebCore/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
8 years, 6 months ago (2012-06-05 01:09:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698