Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: runtime/vm/flow_graph_compiler_x64.h

Issue 10477020: Move inlined type checking code to new compiler ia32. Sharing more and more code between ia32/x64 (… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_shared.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.h
===================================================================
--- runtime/vm/flow_graph_compiler_x64.h (revision 8286)
+++ runtime/vm/flow_graph_compiler_x64.h (working copy)
@@ -78,14 +78,16 @@
PcDescriptors::Kind kind);
// Type checking helper methods.
- void CheckClassIds(const GrowableArray<intptr_t>& class_ids,
- Label* is_instance_lbl,
- Label* is_not_instance_lbl);
+ virtual void CheckClassIds(Register class_id_reg,
+ const GrowableArray<intptr_t>& class_ids,
+ Label* is_instance_lbl,
+ Label* is_not_instance_lbl);
+
RawSubtypeTestCache* GenerateInlineInstanceof(intptr_t cid,
intptr_t token_index,
const AbstractType& type,
- Label* is_instance,
- Label* is_not_instance);
+ Label* is_instance_lbl,
+ Label* is_not_instance_lbl);
RawSubtypeTestCache* GenerateInstantiatedTypeWithArgumentsTest(
intptr_t cid,
@@ -101,9 +103,9 @@
Label* is_not_instance_lbl);
RawSubtypeTestCache* GenerateUninstantiatedTypeTest(
- const AbstractType& dst_type,
intptr_t cid,
intptr_t token_index,
+ const AbstractType& dst_type,
Label* is_instance_lbl,
Label* is_not_instance_label);
@@ -126,6 +128,21 @@
const AbstractType& type,
bool negate_result);
+ enum TypeTestStubKind {
+ kTestTypeOneArg,
+ kTestTypeTwoArgs,
+ kTestTypeThreeArgs,
+ };
+
+ RawSubtypeTestCache* GenerateCallSubtypeTestStub(TypeTestStubKind test_kind,
+ Register instance_reg,
+ Register type_arguments_reg,
+ Register temp_reg,
+ Label* is_instance_lbl,
+ Label* is_not_instance_lbl);
+
+ void GenerateBoolToJump(Register bool_reg, Label* is_true, Label* is_false);
+
void CopyParameters();
virtual void GenerateInlinedGetter(intptr_t offset);
« no previous file with comments | « runtime/vm/flow_graph_compiler_shared.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698