runtime/vm/flow_graph_compiler_shared.h - Issue 10477020: Move inlined type checking code to new compiler ia32. Sharing more and more code between ia32/x64 (…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_shared.h

Issue 10477020: Move inlined type checking code to new compiler ia32. Sharing more and more code between ia32/x64 (… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/flow_graph_compiler_ia32.cc ('K') | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_shared.cc » ('j') | runtime/vm/flow_graph_compiler_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/vm/flow_graph_compiler_shared.h

===================================================================

--- runtime/vm/flow_graph_compiler_shared.h (revision 8254)

+++ runtime/vm/flow_graph_compiler_shared.h (working copy)

@@ -118,6 +118,16 @@

intptr_t argument_count,

const Array& argument_names);

+ void GenerateNumberTypeCheck(Register kClassIdReg,

+ const AbstractType& type,

+ Label* is_instance_lbl,

+ Label* is_not_instance_lbl);

+ void GenerateStringTypeCheck(Register kClassIdReg,

+ Label* is_instance_lbl,

+ Label* is_not_instance_lbl);

+ void GenerateListTypeCheck(Register kClassIdReg,

+ Label* is_instance_lbl);

void GenerateDeferredCode();

@@ -137,6 +147,10 @@

virtual intptr_t EmitStaticCall(const Function& function,

const Array& arguments_descriptor,

intptr_t argument_count) = 0;

+ virtual void CheckClassIds(Register class_id_reg,

+ const GrowableArray<intptr_t>& class_ids,

+ Label* is_equal_lbl,

+ Label* is_not_equal_lbl) = 0;

struct BlockInfo : public ZoneAllocated {

« runtime/vm/flow_graph_compiler_ia32.cc ('K') | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_shared.cc » ('j') | runtime/vm/flow_graph_compiler_x64.cc » ('J')