Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 10477012: Reverting Temporal increase of test timeouts for ASAN image. (Closed)

Created:
8 years, 6 months ago by glotov
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Reverting Temporal increase of test timeouts for ASAN image. FYI: http://codereview.chromium.org/10449086/ BUG=chromium-os:24567 TEST=unit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/test/test_timeouts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
glotov
Hi! FYI
8 years, 6 months ago (2012-06-04 14:26:09 UTC) #1
Alexander Potapenko
8 years, 6 months ago (2012-06-05 14:04:54 UTC) #2
LGTM
Did this help?
On Jun 4, 2012 6:26 PM, <glotov@chromium.org> wrote:

> Reviewers: Alexander Potapenko,
>
> Message:
> Hi! FYI
>
> Description:
> Reverting Temporal increase of test timeouts for ASAN image.
>
> FYI:
http://codereview.chromium.**org/10449086/<http://codereview.chromium.org/104...
>
> BUG=chromium-os:24567
> TEST=unit
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=140278<https://src.chromium.org/viewvc/chrome?view=rev&revision=140278>
>
> Please review this at
http://codereview.chromium.**org/10477012/<http://codereview.chromium.org/104...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/test/test_timeouts.cc
>
>
> Index: base/test/test_timeouts.cc
> diff --git a/base/test/test_timeouts.cc b/base/test/test_timeouts.cc
> index 163ed6e08e1986d9a1f04c386b2cc8**db2896d1e9..**
> dc7f2431fe60a0ecf51b89a052c9d8**58f2273eea 100644
> --- a/base/test/test_timeouts.cc
> +++ b/base/test/test_timeouts.cc
> @@ -12,7 +12,7 @@
>  namespace {
>
>  #ifdef ADDRESS_SANITIZER
> -static const int kTimeoutMultiplier = 6;
> +static const int kTimeoutMultiplier = 2;
>  #else
>  static const int kTimeoutMultiplier = 1;
>  #endif
>
>
>

Powered by Google App Engine
This is Rietveld 408576698