Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10477010: Fix some editor warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comment. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 78cf2e9945b880cd96422cf77cc58ee51672f01a..68e4738e1ff0b0f3981904687afa5f7045cca825 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -2384,10 +2384,7 @@ class HLabeledBlockInformation implements HStatementInformation {
class LoopTypeVisitor extends AbstractVisitor {
const LoopTypeVisitor();
- int visitNode(Node node) {
- // TODO(lrn): Need a compiler object here.
- compiler.internalError('visitNode should not be called', node: node);
- }
+ int visitNode(Node node) => HLoopBlockInformation.NOT_A_LOOP;
int visitWhile(While node) => HLoopBlockInformation.WHILE_LOOP;
int visitFor(For node) => HLoopBlockInformation.FOR_LOOP;
int visitDoWhile(DoWhile node) => HLoopBlockInformation.DO_WHILE_LOOP;
@@ -2399,6 +2396,7 @@ class HLoopBlockInformation implements HStatementInformation {
static final int FOR_LOOP = 1;
static final int DO_WHILE_LOOP = 2;
static final int FOR_IN_LOOP = 3;
+ static final int NOT_A_LOOP = -1;
final int kind;
final HExpressionInformation initializer;
@@ -2468,9 +2466,7 @@ class HAndOrBlockInformation implements HExpressionInformation {
// We don't currently use HAndOrBlockInformation.
HInstruction get conditionExpression() {
- // TODO(lrn): Need a compiler object.
- compiler.internalError('conditionExpression should not be called',
- instruction: this);
+ return null;
}
bool accept(HExpressionInformationVisitor visitor) =>
visitor.visitAndOrInfo(this);
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/variable_allocator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698