Chromium Code Reviews| Index: lib/compiler/implementation/ssa/nodes.dart |
| diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart |
| index ee0543745d8de53a43f66ee8ef287079267753bc..c83191352f5d483f01059f61fdebcf10798141b3 100644 |
| --- a/lib/compiler/implementation/ssa/nodes.dart |
| +++ b/lib/compiler/implementation/ssa/nodes.dart |
| @@ -2377,10 +2377,7 @@ class HLabeledBlockInformation implements HStatementInformation { |
| class LoopTypeVisitor extends AbstractVisitor { |
| const LoopTypeVisitor(); |
| - int visitNode(Node node) { |
| - // TODO(lrn): Need a compiler object here. |
| - compiler.internalError('visitNode should not be called', node: node); |
| - } |
| + int visitNode(Node node) => -1; |
|
karlklose
2012/06/04 11:54:32
NOT_A_LOOP?
Lasse Reichstein Nielsen
2012/06/04 12:09:17
Done.
|
| int visitWhile(While node) => HLoopBlockInformation.WHILE_LOOP; |
| int visitFor(For node) => HLoopBlockInformation.FOR_LOOP; |
| int visitDoWhile(DoWhile node) => HLoopBlockInformation.DO_WHILE_LOOP; |
| @@ -2392,6 +2389,7 @@ class HLoopBlockInformation implements HStatementInformation { |
| static final int FOR_LOOP = 1; |
| static final int DO_WHILE_LOOP = 2; |
| static final int FOR_IN_LOOP = 3; |
| + static final int NOT_A_LOOP = -1; |
| final int kind; |
| final HExpressionInformation initializer; |
| @@ -2461,9 +2459,7 @@ class HAndOrBlockInformation implements HExpressionInformation { |
| // We don't currently use HAndOrBlockInformation. |
| HInstruction get conditionExpression() { |
| - // TODO(lrn): Need a compiler object. |
| - compiler.internalError('conditionExpression should not be called', |
| - instruction: this); |
| + return null; |
| } |
| bool accept(HExpressionInformationVisitor visitor) => |
| visitor.visitAndOrInfo(this); |