Add ShellIntegration::ActivateMetroChrome, which launches Chrome in metro-mode on Windows 8.

Add ShellIntegration::ActivateMetroChrome, which launches Chrome in metro-mode on Windows 8.

BUG=113326
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139975

[robertshield, 2012-05-31 15:14:33]

lg, one request :)

https://chromiumcodereview.appspot.com/10470002/diff/1/chrome/browser/shell_i...
File chrome/browser/shell_integration_win.cc (right):

https://chromiumcodereview.appspot.com/10470002/diff/1/chrome/browser/shell_i...
chrome/browser/shell_integration_win.cc:47: const char kActivateApplication[] =
"ActivateApplication";
could we move this method name and the typedef of the method signature below
into a metro_exports.h header? Once done, I'll do a pass through for other metro
GetProcAddress instances and move those into the new header.

[grt (UTC plus 2), 2012-05-31 15:42:07]

PTAL

[robertshield, 2012-05-31 15:57:25]

LGTM++. Thanks for adding the exports header!

[commit-bot: I haz the power, 2012-05-31 17:18:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10470002/6003

[commit-bot: I haz the power, 2012-05-31 17:18:54]

Presubmit check for 10470002-6003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

Presubmit checks took 1.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[grt (UTC plus 2), 2012-05-31 17:27:32]

+brettw for base OWNERS review

[brettw, 2012-05-31 19:32:08]

LGTM with namespace change

https://chromiumcodereview.appspot.com/10470002/diff/6003/base/win/metro_expo...
File base/win/metro_exports.h (right):

https://chromiumcodereview.appspot.com/10470002/diff/6003/base/win/metro_expo...
base/win/metro_exports.h:16: namespace metro_exports {
This should be in the base::win namespace. I'd remove this metro_exports one. I
think there's little enough in this namespace that your names are sufficiently
unique, especially since this is an API function.

[grt (UTC plus 2), 2012-06-01 02:45:44]

Thanks, Brett.

https://chromiumcodereview.appspot.com/10470002/diff/6003/base/win/metro_expo...
File base/win/metro_exports.h (right):

https://chromiumcodereview.appspot.com/10470002/diff/6003/base/win/metro_expo...
base/win/metro_exports.h:16: namespace metro_exports {
On 2012/05/31 19:32:08, brettw wrote:
> This should be in the base::win namespace. I'd remove this metro_exports one.
I
> think there's little enough in this namespace that your names are sufficiently
> unique, especially since this is an API function.

Done.

[commit-bot: I haz the power, 2012-06-01 02:46:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10470002/10002

[cpu_(ooo_6.6-7.5), 2012-06-01 02:59:38]

note that we also have base\win\metro.h and .cc can you please unify your new
files into them?

[grt (UTC plus 2), 2012-06-01 03:18:53]

On 2012/06/01 02:59:38, cpu wrote:
> note that we also have base\win\metro.h and .cc can you please unify your new
> files into them?

Done.

[commit-bot: I haz the power, 2012-06-01 03:19:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10470002/14009

[commit-bot: I haz the power, 2012-06-01 05:26:26]

Change committed as 139975