tools/grokdump.py - Issue 10467003: Fix grokdump inspector search for invalid addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grokdump.py

Issue 10467003: Fix grokdump inspector search for invalid addresses. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grokdump.py

diff --git a/tools/grokdump.py b/tools/grokdump.py

index 2227635d3fa6c9f6a4db75e04304eb212c20410a..a9f0cb9ddc282c5caab171f69f610720bf27bf15 100755

--- a/tools/grokdump.py

+++ b/tools/grokdump.py

@@ -1462,6 +1462,9 @@ class InspectionShell(cmd.Cmd):

for slot in xrange(start,

start + self.reader.PointerSize() * 10,

self.reader.PointerSize()):

+ if not self.reader.IsValidAddress(slot):

+ print "Address is not contained within the minidump!"

+ return

maybe_address = self.reader.ReadUIntPtr(slot)

heap_object = self.padawan.SenseObject(maybe_address)

print "%s: %s %s" % (self.reader.FormatIntPtr(slot),

« no previous file with comments | « no previous file | no next file » | no next file with comments »